Fix typo in cpp/build.sh #2953

mreso · 2024-02-21T21:40:48Z

Description

This PR fixes a typo ion our build.sh

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Test A

rm -rf _build/_deps/sentencepiece-build/
(serve) ubuntu@ip-172-31-55-226:~/serve/cpp$ ./build.sh
BASE_DIR=/home/ubuntu/serve/cpp
Detected platform: Linux
/home/ubuntu/serve/cpp/_build/_deps/folly-build/installed
[ INFO ] Skip install kineto on Linux
[ INFO ] libtorch is installed
[ INFO ] Building sentencepiece
CMake Deprecation Warning at CMakeLists.txt:15 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


-- VERSION: 0.1.99
-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Not Found TCMalloc: TCMALLOC_LIB-NOTFOUND
-- Configuring done (0.4s)
-- Generating done (0.0s)
-- Build files have been written to: /home/ubuntu/serve/cpp/_build/_deps/sentencepiece-build
[  2%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/builder.cc.o
[  2%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/unicode_script.cc.o
[  3%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/trainer_factory.cc.o
[  4%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/trainer_interface.cc.o
[  4%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/unigram_model_trainer.cc.o
[  6%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/word_model_trainer.cc.o
[  6%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/bpe_model_trainer.cc.o
[  7%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/arena.cc.o
[  7%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/arenastring.cc.o
[  8%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/sentencepiece_trainer.cc.o
[  9%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/pretokenizer_for_training.cc.o
[ 10%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/arena.cc.o
[ 11%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/bytestream.cc.o
[ 12%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/coded_stream.cc.o
[ 14%] Building CXX object src/CMakeFiles/sentencepiece_train-static.dir/char_model_trainer.cc.o
[ 14%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/arenastring.cc.o
[ 15%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/common.cc.o
[ 16%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/bytestream.cc.o
[ 17%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/extension_set.cc.o
[ 18%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/coded_stream.cc.o
[ 19%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/common.cc.o
[ 20%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/generated_enum_util.cc.o
[ 21%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/generated_message_table_driven_lite.cc.o
[ 21%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/generated_message_util.cc.o
[ 22%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/extension_set.cc.o
[ 23%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/generated_enum_util.cc.o
[ 23%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/generated_message_table_driven_lite.cc.o
[ 24%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/generated_message_util.cc.o
[ 25%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/implicit_weak_message.cc.o
[ 26%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/implicit_weak_message.cc.o
[ 27%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/int128.cc.o
[ 28%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/io_win32.cc.o
[ 29%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/message_lite.cc.o
[ 30%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/parse_context.cc.o
[ 31%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/int128.cc.o
[ 32%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/repeated_field.cc.o
[ 33%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/status.cc.o
[ 33%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/statusor.cc.o
[ 34%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/io_win32.cc.o
[ 35%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/message_lite.cc.o
[ 36%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/parse_context.cc.o
In file included from /usr/include/string.h:495,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/stubs/port.h:39,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/stubs/macros.h:34,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/stubs/common.h:46,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/message_lite.h:45,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/third_party/protobuf-lite/message_lite.cc:36:
In function ‘void* memcpy(void*, const void*, size_t)’,
    inlined from ‘google::protobuf::uint8* google::protobuf::io::EpsCopyOutputStream::WriteRaw(const void*, int, google::protobuf::uint8*)’ at /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/io/coded_stream.h:699:16,
    inlined from ‘bool google::protobuf::MessageLite::SerializePartialToZeroCopyStream(google::protobuf::io::ZeroCopyOutputStream*) const’ at /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/implicit_weak_message.h:85:28:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:33: warning: ‘void* __builtin___memcpy_chk(void*, const void*, long unsigned int, long unsigned int)’ specified size between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
   34 |   return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
      |          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 37%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/repeated_field.cc.o
[ 38%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/status.cc.o
[ 39%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/stringpiece.cc.o
[ 40%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/stringprintf.cc.o
[ 41%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/structurally_valid.cc.o
[ 42%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/strutil.cc.o
[ 43%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/time.cc.o
[ 43%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/statusor.cc.o
[ 44%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/stringpiece.cc.o
[ 45%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/wire_format_lite.cc.o
[ 46%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/zero_copy_stream.cc.o
[ 46%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/zero_copy_stream_impl.cc.o
In file included from /usr/include/string.h:495,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/stubs/port.h:39,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/stubs/macros.h:34,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/stubs/common.h:46,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/message_lite.h:45,
                 from /home/ubuntu/serve/cpp/third-party/sentencepiece/third_party/protobuf-lite/message_lite.cc:36:
In function ‘void* memcpy(void*, const void*, size_t)’,
    inlined from ‘google::protobuf::uint8* google::protobuf::io::EpsCopyOutputStream::WriteRaw(const void*, int, google::protobuf::uint8*)’ at /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/io/coded_stream.h:699:16,
    inlined from ‘bool google::protobuf::MessageLite::SerializePartialToZeroCopyStream(google::protobuf::io::ZeroCopyOutputStream*) const’ at /home/ubuntu/serve/cpp/third-party/sentencepiece/src/../third_party/protobuf-lite/google/protobuf/implicit_weak_message.h:85:28:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:33: warning: ‘void* __builtin___memcpy_chk(void*, const void*, long unsigned int, long unsigned int)’ specified size between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
   34 |   return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
      |          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 47%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/__/third_party/protobuf-lite/zero_copy_stream_impl_lite.cc.o
[ 48%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/stringprintf.cc.o
[ 49%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/structurally_valid.cc.o
[ 50%] Building CXX object src/CMakeFiles/sentencepiece-static.dir/builtin_pb/sentencepiece.pb.cc.o
[ 51%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/strutil.cc.o
[ 52%] Building CXX object src/CMakeFiles/sentencepiece.dir/__/third_party/protobuf-lite/time.cc.o
        libisc-9.16.48-Ubuntu.so -> libisc-9.16.48-Ubuntu.so
        libwavpack.so.1 -> libwavpack.so.1.2.1
        libvtkRenderingOpenGL-6.3.so.6.3 -> libvtkRenderingOpenGL-6.3.so.6.3.0
        libtss2-esys.so.0 -> libtss2-esys.so.0.0.0
        libnvidia-gtk3.so.535.104.12 -> libnvidia-gtk3.so.535.104.12
        libvtkFiltersProgrammable-6.3.so.6.3 -> libvtkFiltersProgrammable-6.3.so.6.3.0
        libgphoto2_port.so.12 -> libgphoto2_port.so.12.0.0
        libtiff.so.5 -> libtiff.so.5.5.0
        libfuse.so.2 -> libfuse.so.2.9.9
        libsoup-gnome-2.4.so.1 -> libsoup-gnome-2.4.so.1.9.0
        libopencv_plot.so.4.2 -> libopencv_plot.so.4.2.0
        libvtkIOMINC-6.3.so.6.3 -> libvtkIOMINC-6.3.so.6.3.0
        libHalf.so.24 -> libHalf.so.24.0.0
        libboost_program_options.so.1.71.0 -> libboost_program_options.so.1.71.0
/lib32:
        libpcprofile.so -> libpcprofile.so
        libnss_dns.so.2 -> libnss_dns-2.31.so
        libGLESv2_nvidia.so.2 -> libGLESv2_nvidia.so.535.104.12
/sbin/ldconfig.real: /lib32/ld-2.31.so is the dynamic linker, ignoring

        ld-linux.so.2 -> ld-2.31.so
        libnvidia-opticalflow.so.1 -> libnvidia-opticalflow.so.535.104.12
        libSegFault.so -> libSegFault.so
        libthread_db.so.1 -> libthread_db-1.0.so
        libnss_files.so.2 -> libnss_files-2.31.so
        libnss_nis.so.2 -> libnss_nis-2.31.so
        libanl.so.1 -> libanl-2.31.so
        libGLESv1_CM_nvidia.so.1 -> libGLESv1_CM_nvidia.so.535.104.12
        libGLX_nvidia.so.0 -> libGLX_nvidia.so.535.104.12
        libnvidia-allocator.so.1 -> libnvidia-allocator.so.535.104.12
        libnss_hesiod.so.2 -> libnss_hesiod-2.31.so
        libnvidia-fbc.so.1 -> libnvidia-fbc.so.535.104.12
        libmemusage.so -> libmemusage.so
        libnvidia-tls.so.535.104.12 -> libnvidia-tls.so.535.104.12
        libgcc_s.so.1 -> libgcc_s.so.1
        libBrokenLocale.so.1 -> libBrokenLocale-2.31.so
        libnsl.so.1 -> libnsl-2.31.so
        libnss_nisplus.so.2 -> libnss_nisplus-2.31.so
        libnvidia-glcore.so.535.104.12 -> libnvidia-glcore.so.535.104.12
        libnvidia-nvvm.so.4 -> libnvidia-nvvm.so.535.104.12
        libresolv.so.2 -> libresolv-2.31.so
        libEGL_nvidia.so.0 -> libEGL_nvidia.so.535.104.12
        libcuda.so.1 -> libcuda.so.535.104.12
        libutil.so.1 -> libutil-2.31.so
        libstdc++.so.6 -> libstdc++.so.6.0.28
        libnvidia-ml.so.1 -> libnvidia-ml.so.535.104.12
        libnvidia-ptxjitcompiler.so.1 -> libnvidia-ptxjitcompiler.so.535.104.12
        libm.so.6 -> libm-2.31.so
        libnvcuvid.so.1 -> libnvcuvid.so.535.104.12
        libnvidia-glvkspirv.so.535.104.12 -> libnvidia-glvkspirv.so.535.104.12
        librt.so.1 -> librt-2.31.so
        libc.so.6 -> libc-2.31.so
        libnvidia-eglcore.so.535.104.12 -> libnvidia-eglcore.so.535.104.12
        libnvidia-opencl.so.1 -> libnvidia-opencl.so.535.104.12
        libOpenCL.so.1 -> libOpenCL.so.1.0.0
        libdl.so.2 -> libdl-2.31.so
        libpthread.so.0 -> libpthread-2.31.so
        libnvidia-glsi.so.535.104.12 -> libnvidia-glsi.so.535.104.12
        libnss_compat.so.2 -> libnss_compat-2.31.so
        libnvidia-encode.so.1 -> libnvidia-encode.so.535.104.12
/lib:
        libmultipath.so.0 -> libmultipath.so.0
        libmpathcmd.so.0 -> libmpathcmd.so.0
        libdmmp.so.0.2.0 -> libdmmp.so.0.2.0
        libmpathpersist.so.0 -> libmpathpersist.so.0
        libarmadillo.so.9 -> libarmadillo.so.9.800.4
        libvpf.so.4.1 -> libvpf.so.4.1
        liblustreapi.so.1 -> liblustreapi.so.1.0.0
        libgdal.so.26 -> libgdal.so.26.0.4
        libdfalt.so.0 -> libdfalt.so.0.0.0
        libhandle.so.1 -> libhandle.so.1.0.3
        liblnetconfig.so.4 -> liblnetconfig.so.4.0.0
        libmfhdfalt.so.0 -> libmfhdfalt.so.0.0.0
        libogdi.so.4.1 -> libogdi.so.4.1
[ INFO ] sentencepiece is installed

Checklist:

Did you have fun?

chauhang · 2024-02-22T00:01:38Z

Thanks @mreso the build went through fine this time. There was one test failing and one skipped at the end, is that expected? Tested using latest PT nightlies:

[----------] Global test environment tear-down
[==========] 47 tests from 11 test suites ran. (2077 ms total)
[  PASSED  ] 45 tests.
[  SKIPPED ] 1 test, listed below:
[  SKIPPED ] ModelPredictTest.TestLoadPredictLlamaCppHandler
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ModelPredictTest.TestLoadPredictAotInductorLlamaHandler

* Fix typo in build.sh * Add missing environment flag in cpp/README.md * Updated cpp/README.md

Fix typo in build.sh

21907b0

mreso requested review from lxning and chauhang February 21, 2024 21:40

mreso marked this pull request as ready for review February 21, 2024 21:41

Add missing environment flag in cpp/README.md

583a7f7

lxning approved these changes Feb 22, 2024

View reviewed changes

lxning added this pull request to the merge queue Feb 22, 2024

mreso removed this pull request from the merge queue due to a manual request Feb 22, 2024

Merge branch 'master' into fix/build.sh

bd51dc6

mreso enabled auto-merge February 22, 2024 04:00

mreso disabled auto-merge February 22, 2024 04:11

Updated cpp/README.md

8ae7de7

mreso enabled auto-merge February 22, 2024 04:54

mreso added this pull request to the merge queue Feb 22, 2024

Merged via the queue into master with commit 995fcf8 Feb 22, 2024
15 of 17 checks passed

chauhang added this to the v0.10.0 milestone Feb 27, 2024

muthuraj-i2i pushed a commit to muthuraj-i2i/serve that referenced this pull request Mar 1, 2024

Fix typo in cpp/build.sh (pytorch#2953)

e5e04ea

* Fix typo in build.sh * Add missing environment flag in cpp/README.md * Updated cpp/README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typo in cpp/build.sh #2953

Fix typo in cpp/build.sh #2953

mreso commented Feb 21, 2024

chauhang commented Feb 22, 2024

Fix typo in cpp/build.sh #2953

Fix typo in cpp/build.sh #2953

Conversation

mreso commented Feb 21, 2024

Description

Type of change

Feature/Issue validation/testing

Checklist:

chauhang commented Feb 22, 2024