Fix ONNX symbolic for argmin and argmax #18261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zasdfgbnm
reviewed
Mar 21, 2019
| @@ -1690,10 +1690,10 @@ def narrow(g, input, dim, start, length): | |||
|
|
|||
|
|
|||
| @parse_args('v', 'i', 'i') | |||
| def _argmax(g, input, dim, keepdim): | |||
| def argmax(g, input, dim, keepdim): | |||
There was a problem hiding this comment.
What would happen if dim=None? Does this need special handling?
There was a problem hiding this comment.
this is another feature we need to support. if dim is None, if it will do the argmax on the flattened tensor. I will add this support in a different PR.
|
#18263 to track this issue. I will land this diff as it is to fix the CI. |
|
Thanks for fixing it so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem introduced in #17103