Insights Fixes #526
Closed
Insights Fixes #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
NarineK
pushed a commit
to NarineK/captum-1
that referenced
this pull request
Nov 19, 2020
Summary: Insights example no longer worked after building master. This seems to be because of 2 issues: 1. Paths in setup.py needed to be updated after this refactoring pytorch#419 . 2. cifar_torchvision.pt seems to have been corrupted when this file was moved in pytorch#419, based on comparing the sizes in these 2 revisions: https://github.com/pytorch/captum/blob/9bcf257f9b3811230f370ced1b0801d8df5aa9ee/captum/insights/models/cifar_torchvision.pt - > 244 KB https://github.com/pytorch/captum/blob/master/captum/insights/attr_vis/models/cifar_torchvision.pt - >239 KB (master) It seems like this was caused by the new file not being detected as binary, causing some corruption when pushed. This updates gitattributes to treat all .pt files as binary. Pull Request resolved: pytorch#526 Reviewed By: bilalsal Differential Revision: D24952285 Pulled By: vivekmig fbshipit-source-id: 77b54caad7a4f2d2888ea59260603e00d62748ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insights example no longer worked after building master. This seems to be because of 2 issues:
https://github.com/pytorch/captum/blob/9bcf257f9b3811230f370ced1b0801d8df5aa9ee/captum/insights/models/cifar_torchvision.pt - > 244 KB
https://github.com/pytorch/captum/blob/master/captum/insights/attr_vis/models/cifar_torchvision.pt - >239 KB (master)
It seems like this was caused by the new file not being detected as binary, causing some corruption when pushed. This updates gitattributes to treat all .pt files as binary.