Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captum Insights not working in Google Colab #116

Closed
floscha opened this issue Oct 11, 2019 · 9 comments
Closed

Captum Insights not working in Google Colab #116

floscha opened this issue Oct 11, 2019 · 9 comments
Assignees
Labels
bug Something isn't working insights triaged

Comments

@floscha
Copy link

floscha commented Oct 11, 2019

When trying to run the Getting started with Captum Insights tutorial in a Google Colab notebook, I stumbled upon the following issue: When calling visualizer.render(debug=False), the result looks like in the screenshot below.

Screenshot 2019-10-11 at 21 05 48

The reason for this behavior is that Captum's render() method does not redirect requests as e.g. shown in TensorBoard's _display_colab() method. While the current implementation works fine with regular IPython notebooks, Colab requires some additional tweaks as described in the TensorBoard code.

Do you have any plans to support Colab or is this even a priority? If no one is already working on this, I could make a PR adding some code similar to TensorBoard as a proof of concept.

@NarineK
Copy link
Contributor

NarineK commented Oct 11, 2019

Hi @floscha , thank you so much for posting the issue. Google Colab notebook support would be great! We haven't had time to look into it. cc: @edward-io

@edward-io
Copy link
Contributor

Feel free to give it a shot and send in a PR. Thanks!

@orionr
Copy link
Contributor

orionr commented Oct 24, 2019

This would be excellent! I wonder if this is also the issue seen in SageMaker at #138 . @edward-io and @J0Nreynolds, thoughts?

@orionr
Copy link
Contributor

orionr commented Oct 30, 2019

@J0Nreynolds is going to investigate here as well.

@eburling
Copy link

This will be essential for all remote work beyond Colab, too, e.g. if running a jupyter lab server on a remote cluster.

@edward-io
Copy link
Contributor

edward-io commented Nov 13, 2019

@eburling master should be working in remote Jupyter deployments after #124 , Colab has some special requirements. Let us know if its giving you issues.

@J0Nreynolds
Copy link
Contributor

A fix allowing Captum Insights to run in Colab notebooks will be merged soon: #255

Thanks @floscha for showing us TensorBoard's _display_colab method as a reference. The fix was very similar to that.

@floscha
Copy link
Author

floscha commented Jan 28, 2020

Great job @J0Nreynolds!

@NarineK
Copy link
Contributor

NarineK commented Feb 8, 2020

@floscha , @J0Nreynolds if this is merged and working, can we close the issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working insights triaged
Projects
None yet
Development

No branches or pull requests

6 participants