Use greenlets rather than threads for sync loop #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oremanj
force-pushed
the
sync-with-greenlet
branch
from
23b84cf
to
cedaef3
Compare
|
Could perhaps add a regression test that spins up an ipython prompt and attempts to import |
|
I tested that manually; it doesn't seem worth adding a test dependency on IPython just for this. The previous error was because the event loop is a per-thread construct and we were trying to run it in a different thread; honestly I'm surprised it appeared to work as far as it did. |
Zac-HD
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132.