Skip to content

Commit

Permalink
Skip a newly-added hanging test
Browse files Browse the repository at this point in the history
  • Loading branch information
oremanj committed Jan 30, 2024
1 parent fb2218c commit 3dd1657
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,12 @@ def pytest_collection_modifyitems(items):
by_id = {item.nodeid: item for item in items}
aio_test_root = aio_test_nodeid(asyncio_test_dir / "foo")[:-3]

def mark(marker, rel_id):
def mark(marker, rel_id, may_be_absent=False):
try:
by_id[aio_test_root + rel_id].add_marker(marker)
except KeyError:
if may_be_absent:
return
warnings.warn(
"Tried to add marker {} to {}, but that test doesn't exist.".format(
marker, rel_id
Expand Down Expand Up @@ -190,6 +192,15 @@ def skip(rel_id):
skip("test_events.py::TestPyGetEventLoop::test_get_event_loop_new_process")
skip("test_events.py::TestCGetEventLoop::test_get_event_loop_new_process")

# This test attempts to stop the event loop from within a
# run_until_complete coroutine, which hangs on our implementation.
# Only present on releases post November 2023
mark(
pytest.mark.skip,
"test_streams.py::StreamTests::test_loop_is_closed_resource_warnings",
may_be_absent=True,
)

if sys.version_info >= (3, 9):
# This tries to create a new loop from within an existing one,
# which we don't support.
Expand Down

0 comments on commit 3dd1657

Please sign in to comment.