Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all project configuration from setup.py to pyproject.toml #41

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

CoolCat467
Copy link
Member

@CoolCat467 CoolCat467 commented May 22, 2024

In this pull request, I moved all project configuration from setup.py to pyproject.toml.

  • Changed the order lines appear in to be identical to Trio's configuration file.
  • Added Programming Language :: Python :: 3 :: Only classifier
  • Enabled mypy local_partial_types while I'm at it, makes no changes but ensures behaviour is identical to when mypy is running in daemon mode.

Changed continuous integration script to be similar to Trio, adding groups and switching to pyproject based install instead of setup.py script

Enabled mypy `local_partial_types` while I'm at it, makes no changes but ensures behaviour is identical to when mypy is running in daemon mode.
@CoolCat467
Copy link
Member Author

Having an issue with setup-python:

Version 3.7 was not found in the local cache
Error: The version '3.7' with architecture 'arm64' was not found for macOS 14.4.1.
The list of all available versions can be found here: https://github.com/raw/actions/python-versions/main/versions-manifest.json

@A5rocks
Copy link
Contributor

A5rocks commented May 22, 2024

Either we can drop 3.7 cause it's EOL or we can change macos-latest to macos-13

If we drop 3.7 we can do that in two PRs: remove it from CI here then simplify code/change documentation in another.

@CoolCat467
Copy link
Member Author

Either we can drop 3.7 cause it's EOL or we can change macos-latest to macos-13

If we drop 3.7 we can do that in two PRs: remove it from CI here then simplify code/change documentation in another.

Removed 3.7 from CI

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, minor feedback. Also it's a bit strange that you added all the towncrier, but I suppose it's there for explicitness/making sure we have the same conventions as trio? Then that's fine by me.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@CoolCat467
Copy link
Member Author

Also it's a bit strange that you added all the towncrier, but I suppose it's there for explicitness/making sure we have the same conventions as trio? Then that's fine by me.

Yes, explicitness and making the same as Trio

@CoolCat467 CoolCat467 requested a review from A5rocks May 24, 2024 04:46
Copy link
Contributor

@TeamSpen210 TeamSpen210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only noticed two very minor things.

ci.sh Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot this was a thing

@CoolCat467 CoolCat467 merged commit 6a3192f into python-trio:master Jul 4, 2024
17 checks passed
@CoolCat467 CoolCat467 deleted the switch-to-pyproject branch July 4, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants