Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for async900 decorators #279

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Aug 7, 2024

Fixes #277.

@Zac-HD Zac-HD requested a review from jakkdl August 7, 2024 08:06
@Zac-HD Zac-HD force-pushed the transform-async-generator-decorators branch from 0d8eecc to 6992a71 Compare August 7, 2024 08:29
@Zac-HD Zac-HD force-pushed the transform-async-generator-decorators branch from 6992a71 to ca62419 Compare August 7, 2024 08:36
@Zac-HD Zac-HD merged commit f0ff928 into main Aug 7, 2024
10 checks passed
@Zac-HD Zac-HD deleted the transform-async-generator-decorators branch August 7, 2024 15:31
Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@@ -54,3 +54,12 @@ async def cm():
async def another_non_generator():
def foo():
yield


# ARG --transform-async-generator-decorators=this_is_like_a_context_manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I'd probably have this at the top of the file for readability (and in all other files I've had them at the top), esp as it pops up in the other error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user-configured decorator names to disable ASYNC900
2 participants