Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make async913 disabled by default #259

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented May 28, 2024

oopsies

@jakkdl jakkdl enabled auto-merge (squash) May 28, 2024 08:24
@jakkdl jakkdl disabled auto-merge May 28, 2024 08:25
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, should have noticed in review 😅

@Zac-HD Zac-HD merged commit 315cd5f into python-trio:main May 28, 2024
10 checks passed
@jakkdl
Copy link
Member Author

jakkdl commented May 28, 2024

...although looking at it more closely, we already default --disable to ASYNC9, and what disable_codes_by_default achieves is adding the codes to --ignore. So in effect we're doubly disabling the codes and you have to both --select and --enable them to get run? Seems bad, we probably shouldn't bother with calling
...nvm nope! Turns out we change the default to --disable depending on if we're standalone or not.

This is a jolly mess, which maaybe made sense before flake8 started enforcing three-letter codes in --ignore (and presumably --select). We probably should stop calling option_manager.extend_default_ignore(default_disabled_error_codes) and make --disable always have the default of ASYNC9, and lean into that end-users should only use enable/disable, and never try to use select/ignore.

edit: opened #260 for discussion of the issue

@jakkdl
Copy link
Member Author

jakkdl commented May 28, 2024

should've marked it draft while writing up that comment x)

@jakkdl jakkdl deleted the disable_async913 branch May 29, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants