fix internal error in visitor91x #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkdl
commented
Apr 9, 2024
| @@ x,3 x,4 @@ | ||
| @@ x,6 x,7 @@ |
There was a problem hiding this comment.
Ooooh after some confusion I think I figured out why this line in the diff output got changed. It's because there's now context after the changed line in await_everywhere_except_gen_target (i.e. two empty lines and # Issue #226), so now there's 3 more lines in the diff output.
Comment on lines
212
to
+220
| + await trio.lowlevel.checkpoint() | ||
|
|
||
|
|
||
| # Issue #226 | ||
| @@ x,3 x,4 @@ | ||
| pass | ||
| except Exception: | ||
| pass | ||
| + await trio.lowlevel.checkpoint() |
There was a problem hiding this comment.
once again this looks kinda weird in the github diff view, due to viewing a syntax-highlighted diff file in diff view. But the actual diff is entirely as expected.
| @@ -416,6 +416,7 @@ def _parse_eval_file( | |||
| msg = f"Line {lineno}: Failed to format\n {message!r}\nwith\n{args}" | |||
| raise ParseError(msg) from e | |||
|
|
|||
| assert enabled_codes, "no codes enabled. Fix file name or add `# ARGS --enable=...`" | |||
There was a problem hiding this comment.
minor unrelated QoL when writing new tests to get a nice error message.
Zac-HD
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #226
Underlying issue was different try/except's sharing the same reference to self.try_state, due to not passing
copy=Truetosave_state().I went through the other calls to
save_statein the same visitor and added an explicitcopy=Falseto the only other one that didn't already specify it. It's possiblesave_state()shouldn't have a default at all, or default toTruesince the performance loss from some extra copying would probably be negligible.