Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry does ignores extras_require packages defined in setup.py #3180

Closed
3 tasks done
NixBiks opened this issue Oct 12, 2020 · 5 comments
Closed
3 tasks done

Poetry does ignores extras_require packages defined in setup.py #3180

NixBiks opened this issue Oct 12, 2020 · 5 comments
Labels
status/duplicate Duplicate issues

Comments

@NixBiks
Copy link

NixBiks commented Oct 12, 2020

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: both debian and macOS
  • Poetry version: 1.1.2

Issue

If I run the following poetry add 'camelot-py[cv]' then I correctly get the following in pyproject.toml

[tool.poetry.dependencies]
python = "^3.8"
camelot-py = {extras = ["cv"], version = "^0.8.2"}

But opencv-python is not installed as stated in extras_require in setup.py. If I use pip install 'camelot-py[cv]' then it works as expected

@NixBiks NixBiks added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Oct 12, 2020
@tamuhey
Copy link
Contributor

tamuhey commented Oct 12, 2020

I've confirmed this bug with poetry add modin[dask]

@tamuhey
Copy link
Contributor

tamuhey commented Oct 12, 2020

It doesn't happen with poetry=1.0.10

@abn
Copy link
Member

abn commented Oct 12, 2020

Can you please try the fix at #3147.

Using pipx

pipx install --suffix=@3147 'poetry @ git+https://github.com/python-poetry/poetry.git@refs/pull/3147/head'

Using a container (podman | docker)

podman run --rm -i --entrypoint bash python:3.8 <<EOF
set -e
python -m pip install -q git+https://github.com/python-poetry/poetry.git@refs/pull/3147/head
python -m poetry new foobar
pushd foobar
sed -i /pytest/d pyproject.toml
python -m poetry add 'camelot-py[cv]'
EOF

@abn abn added status/duplicate Duplicate issues and removed status/triage This issue needs to be triaged kind/bug Something isn't working as expected labels Oct 12, 2020
@abn
Copy link
Member

abn commented Oct 12, 2020

Duplicate of #3129

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/duplicate Duplicate issues
Projects
None yet
Development

No branches or pull requests

3 participants