Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov token to python-pillow org #8040

Closed
hugovk opened this issue May 2, 2024 · 3 comments · Fixed by #8041
Closed

Add Codecov token to python-pillow org #8040

hugovk opened this issue May 2, 2024 · 3 comments · Fixed by #8041
Labels

Comments

@hugovk
Copy link
Member

hugovk commented May 2, 2024

Re: #7776

Looks like Codecov aren't changing tack and we're now getting very low coverage for recent PRs.

For example #8039 has 24% (of target 52%, which is also too low):

[2024-05-02T03:52:34.094Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 1708 seconds.', code='throttled')}

https://github.com/python-pillow/Pillow/actions/runs/8918310280/job/24492714641?pr=8039#step:14:216

So let's add a token to the https://github.com/python-pillow org.

@aclark4life Please will you take care of this? I don't have access to the org settings.

  1. Sign in at https://app.codecov.io
  2. Go to https://app.codecov.io/gh/python-pillow/Pillow/settings
  3. Copy the repository upload token
  4. Go to https://github.com/organizations/python-pillow/settings/secrets/actions
  5. Click "New org secret"
  6. Name it CODECOV_ORG_TOKEN and paste in the token, leave "Repo access: Public repos" and "Add secret"

After that, we need to add it to our CI workflows and bump to v4, either like:

- uses: codecov/codecov-action@v4
  with:
    token: ${{ secrets.CODECOV_ORG_TOKEN }}

or:

- uses: codecov/codecov-action@v4
  with:
    ...
  env:
    CODECOV_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }}

https://github.com/marketplace/actions/codecov shows env:, but codecov/feedback#112 also shows the more compact token:.

@hugovk hugovk added the Testing label May 2, 2024
@aclark4life
Copy link
Member

@aclark4life Please will you take care of this? I don't have access to the org settings.

Done!

Screenshot 2024-05-02 at 3 05 26 PM

@hugovk
Copy link
Member Author

hugovk commented May 2, 2024

Thank you!

I'll be travelling for the next few days without a laptop, so can continue with this some time next week unless someone else wants a go!

@radarhere
Copy link
Member

#8041 upgrades to v4 and adds token:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants