Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release process creates a dist/*.egg file #4981

Closed
hugovk opened this issue Oct 14, 2020 · 1 comment · Fixed by #4992
Closed

Release process creates a dist/*.egg file #4981

hugovk opened this issue Oct 14, 2020 · 1 comment · Fixed by #4992
Labels

Comments

@hugovk
Copy link
Member

hugovk commented Oct 14, 2020

What did you do?

Ran make release-test as part of the 8.0.0 release checks.

What did you expect to happen?

Release tests ran. Nothing created in dist/

What actually happened?

Release tests ran. dist/Pillow-8.1.0.dev0-py3.9-macosx-10.9-x86_64.egg was created.

What are your OS, Python and Pillow versions?

  • OS: macOS Mojave
  • Python: 3.9
  • Pillow: 8.0.0

This comes from the python3 setup.py install command. I moved the file away before proceeding, to make sure it wasn't uploaded to PyPI as there wasn't one for the last release:

But now I look again, these have a single egg:

Release egg
https://pypi.org/project/Pillow/7.1.2/#files Pillow-7.1.2-py3.8-macosx-10.9-x86_64.egg
https://pypi.org/project/Pillow/7.1.1/#files Pillow-7.1.1-py3.8-macosx-10.9-x86_64.egg
https://pypi.org/project/Pillow/7.1.0/#files Pillow-7.1.0-py3.8-macosx-10.9-x86_64.egg

We don't need to release a single egg file for a single Python version, right? When we have all the wheels?

If we don't need it, can we prevent python3 setup.py install creating it, or alternatively, update RELEASING.md to remove it?

@hugovk hugovk added the Release label Oct 14, 2020
@hugovk hugovk changed the title Release process creates an dist/*.egg file Release process creates a dist/*.egg file Oct 14, 2020
@radarhere
Copy link
Member

See pypa/setuptools#1347 for the setuptools issue about this.

See #4990 for my suggested solution - a PR that removes the egg file after make release-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants