Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixture.rst #1987

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Update fixture.rst #1987

merged 1 commit into from
Oct 5, 2016

Conversation

GregEremeev
Copy link

Target: master
Removed redundant word

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.949% when pulling 5602532 on Budulianin:master into 50b960c on pytest-dev:master.


*
* Minor fix to the documentation.
Thanks `@budulianin`_ for the PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a changelog entry is needed for this 😉

If you want to keep it, you should not remove the empty lines (which are here to avoid merge conflicts), and would need to add a link reference for your github username.

Copy link
Author

@GregEremeev GregEremeev Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a changelog entry is needed for this

I just followed PR rule

If you want to keep it, you should not remove the empty lines (which are here to avoid merge conflicts), and would need to add a link reference for your github username.

Ok. I will remove empty lines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, we just amended this in #1988.

Copy link
Author

@GregEremeev GregEremeev Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, we just amended this in #1988.

Ok. I removed lines from CHANGELOG.rst

Removed redundant word
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.909% when pulling 65ebc75 on Budulianin:master into cf13355 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.909% when pulling 65ebc75 on Budulianin:master into cf13355 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.909% when pulling 65ebc75 on Budulianin:master into cf13355 on pytest-dev:master.

@nicoddemus
Copy link
Member

Thanks a lot, appreciate it! 😄

@nicoddemus nicoddemus merged commit 3301a1c into pytest-dev:master Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants