Mark refactor #1534
Closed
Mark refactor #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
mark-refactor
branch
2 times, most recently
from
3c191d0
to
0352092
Compare
xfail a few tests that broke discovered a dependent test that breaks as well
RonnyPfannschmidt
force-pushed
the
mark-refactor
branch
from
6668c00
to
8ec6a53
Compare
This was referenced Apr 28, 2016
Merged
|
@RonnyPfannschmidt how's the status of this PR? Can it be reviewed/merged? |
|
I didn't get around fixing the whitespace yet |
|
closing after discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: marks are all over the place and i cant comprehend if/how to stop the issues with "smearing" in a backward compatible
solution: restructure marks so concerns are more separated while keeping backward compatibility