Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deselection incorrectly determines the deselection reason #1372

Closed
RonnyPfannschmidt opened this issue Feb 10, 2016 · 1 comment
Closed

deselection incorrectly determines the deselection reason #1372

RonnyPfannschmidt opened this issue Feb 10, 2016 · 1 comment
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch type: refactoring internal improvements to the code

Comments

@RonnyPfannschmidt
Copy link
Member

the combination of the terminal plugin and the mark plugin assume, only the mark plugin can deselect tests

so that's whats being used in the terminal summary, and the hook for Deselection does not consider getting a deselection Reason

i propose adding a deselection reason too the hook and requiring plugins that deselect to pass it
starting in 3.0

in order to support that we might need to add support for defaults to hook invocation and specification in pluggy
@RonnyPfannschmidt RonnyPfannschmidt added type: enhancement new feature or API change, should be merged into features branch type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: refactoring internal improvements to the code type: feature-branch new feature or API change, should be merged into features branch labels Feb 10, 2016
This was referenced Feb 10, 2016
Closed
Closed
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Apr 20, 2016
Closed
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Aug 1, 2016
@RonnyPfannschmidt
terminal: dont pretend to know the deselection reason
ac215e9 
this addresses pytest-dev#1372 - we pretend we know the deselection reason from internal plugins and ignore 3rd party/local reasons
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Aug 1, 2016
Merged
@nicoddemus
Copy link
Member

Fixed in #1779

This was referenced Aug 24, 2016
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Merged
This was referenced Aug 31, 2016
Merged
Open
This was referenced Nov 15, 2017
Closed
Closed
Closed
Merged
Merged
Closed
Closed
This was referenced Nov 27, 2017
Closed
Closed
Closed
Open
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 6, 2017
Closed
Open
Open
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@pyup-bot pyup-bot mentioned this issue Dec 18, 2017
Closed
@john-dupuy john-dupuy mentioned this issue Aug 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch type: refactoring internal improvements to the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RonnyPfannschmidt @nicoddemus