Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python 3.3 from package classifiers #4784

Closed
wants to merge 2 commits into from
Closed

Remove python 3.3 from package classifiers #4784

wants to merge 2 commits into from

Conversation

rpkilby
Copy link

@rpkilby rpkilby commented Oct 13, 2017

Hello, this seems to have been missed in #4355.

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Oct 14, 2017
pradyunsg
pradyunsg approved these changes Oct 14, 2017
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I'll merge once Travis approves. :)

@benoit-pierre
Copy link
Member

Should the corresponding CI jobs be removed too?

@benoit-pierre
Copy link
Member

@rpkilby: you missed the 2 jobs on AppVeyor.

@rpkilby
Copy link
Author

rpkilby commented Oct 14, 2017

@benoit-pierre - thanks. Can you cancel the jobs for the last commit?

@benoit-pierre
Copy link
Member

benoit-pierre commented Oct 14, 2017 •
edited
Loading

Done on Travis, the AppVeyor build should be automatically canceled if you push a new commit.

@rpkilby
Copy link
Author

rpkilby commented Oct 14, 2017

Hm. Not sure if it's because I updated the existing commit, but the AppVeyor builds still seem to be live. https://ci.appveyor.com/project/pypa/pip/build/1.0.1692

@benoit-pierre
Copy link
Member

Rolling builds are not configured then, could be a good idea to enable them, @pradyunsg do you have the permission to do that? I don't have the right to cancel a build on AppVeyor, so someone else we'll have to do it.

@pradyunsg
Copy link
Member

Wait... I misread. My bad.

3.3 support is not dropped -- it's deprecated. I think the plan is to let it stay for another major version (pip 10 series) and then remove it, which renders the PR premature.

pradyunsg
pradyunsg requested changes Oct 14, 2017
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented above.

@rpkilby rpkilby closed this Oct 14, 2017
@rpkilby rpkilby deleted the patch-1 branch October 14, 2017 08:45
@pradyunsg
Copy link
Member

Thanks for the PR @rpkilby! :)

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg requested changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpkilby @benoit-pierre @pradyunsg