Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save lift tests to InferenceData #833

Open
wd60622 opened this issue Jul 13, 2024 · 1 comment
Open

Save lift tests to InferenceData #833

wd60622 opened this issue Jul 13, 2024 · 1 comment
Labels
bug Something isn't working MMM

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jul 13, 2024

This would be required to rebuild same model after using lift test methods.

Currently missing:

  • save the lift tests to the fit_data group
  • upon load, add the lift tests to the model likelihood
    • Would be done here

An alternative to this would be to save the lift test to a separate group. However, this would likely cause some additional complexity and would have to capture additional warnings. The fit_data just runs the risk of having to change the structure of the fit_data group itself and likely have to have a version bump of the model.

@wd60622 wd60622 added the MMM label Jul 13, 2024
@wd60622 wd60622 changed the title Save lift tests to fit data group Save lift tests to fit_data group Jul 21, 2024
@wd60622
Copy link
Contributor Author

wd60622 commented Jul 23, 2024

The kwargs used with the would have to be saved off as well or the reconstructed model would not be the same

def add_lift_test_measurements(
self,
df_lift_test: pd.DataFrame,
dist: type[pm.Distribution] = pm.Gamma,
name: str = "lift_measurements",
) -> None:

Potentially these kwargs in the attrs like in the save and load methods. This seems to require that each df_lift_test would have to be saved in separate variable? Maybe using another group like lift_tests would be more clear?

@wd60622 wd60622 changed the title Save lift tests to fit_data group Save lift tests to InferenceData Jul 23, 2024
@wd60622 wd60622 added the bug Something isn't working label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MMM
Projects
None yet
Development

No branches or pull requests

1 participant