Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Varying Media not considered in channel_contributions_forward_pass #819

Open
wd60622 opened this issue Jul 9, 2024 · 1 comment
Open
Labels
bug Something isn't working enhancement New feature or request MMM
Milestone

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jul 9, 2024

The time varying contributions are not multiplied out in the method.

Having the time_varying forward pass method might be the way to go

Reference:

pm.Deterministic(
"channel_contributions",
self.forward_pass(x=channel_data),
dims=("date", "channel"),
)

@wd60622 wd60622 added enhancement New feature or request MMM bug Something isn't working labels Jul 9, 2024
@juanitorduz
Copy link
Collaborator

Shall we add this to the 0.8.0 milestone?

@wd60622 wd60622 added this to the 0.8.0 milestone Jul 9, 2024
@wd60622 wd60622 modified the milestones: 0.8.0, 0.9.0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request MMM
Projects
None yet
Development

No branches or pull requests

2 participants