Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for method keyword #807

Closed
wd60622 opened this issue Jul 4, 2024 · 0 comments · Fixed by #974
Closed

Deprecation warning for method keyword #807

wd60622 opened this issue Jul 4, 2024 · 0 comments · Fixed by #974
Labels
good first issue Good for newcomers MMM
Milestone

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jul 4, 2024

          > Model was fitted fine and had acceptable results.. I just wasn't able to use the plot_direct_contribution_curve using  method.. I ran this same exact code in version 0.6.0 and it worked fine..

mmm.plot_direct_contribution_curves(show_fit=True, method='sigmoid',xlim_max=3,same_axes=False)

Try it without the method keyword then. It seems to have been dropped as the fit curve will come from saturation specified at initialization.

@juanitorduz shall we go in an a deprecation? Was this a keyword arg up until this release?

Originally posted by @wd60622 in #804 (comment)

@wd60622 wd60622 added MMM good first issue Good for newcomers labels Jul 4, 2024
@wd60622 wd60622 added this to the 0.8.0 milestone Jul 9, 2024
@wd60622 wd60622 modified the milestones: 0.8.0, 0.9.0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers MMM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant