Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make results fully reproducible #286

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Make results fully reproducible #286

merged 3 commits into from
Jan 5, 2024

Conversation

drbenvincent
Copy link
Collaborator

Problems with doctests passing revealed that we were only passing the random_seed kwarg to the pm.sample method and that this was not being passed into pm.sample_prior_predictive or pm.sample_posterior_predictive.

This will hopefully avoid any future issues in doctest fragility. But it is also a pretty useful (if not essential) fix to make.

Closes #284.

@drbenvincent drbenvincent added the enhancement New feature or request label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4772b34) 76.27% compared to head (ee8515e) 76.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   76.27%   76.50%   +0.22%     
==========================================
  Files          20       20              
  Lines        1332     1345      +13     
==========================================
+ Hits         1016     1029      +13     
  Misses        316      316              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent drbenvincent merged commit 6283c76 into main Jan 5, 2024
10 checks passed
@drbenvincent drbenvincent deleted the random_seed branch January 5, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make docstring examples more stable
2 participants