-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce custom initval
in SMC
#7439
Conversation
@ricardoV94 thanks for the review! Before I revert the formatting changes (thanks VSCode!), I want to address the comment
I guess this is true, and we'll need a different strategy for this fix! If you have any ideas, please let me know. |
Ordered transform is an edge case that keeps posing problems all over the place. Much of this pain would be gone with: #7297 |
What is model.rvs_to_initvals when those are not specified though? I'm not sure the default is moment, my comment was a question not a statement |
Thanks for the clarification @ricardoV94 ! Indeed, the default value for I've also reverted those pesky formatting changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7439 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 103 103
Lines 17263 17263
=======================================
Hits 15914 15914
Misses 1349 1349
|
Thanks @tvwenger! |
@aloctavodia Actually, I think this "fix" causes other issues. When sampling a model with
Presumably, these errors are due to the fact that all of the starting positions are equal, thus there is no variance in the starting particle positions and the denominator of this @jessegrabowski had another idea here that I will try to implement... |
Ohh, I see. Thanks for keep trying to find a good solution |
@aloctavodia the PR should have been squashed+merge, since it had useless / badly titled commits. |
Description
Per the discussion here, it is apparent that SMC does not respect custom
initval
. This is a problem when a custominitval
is required in order to support a transformation, such asOrdered
.Related Issue
initval
#7438Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7439.org.readthedocs.build/en/7439/