Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstrings formatting and add unnamed_distribution to glossary #6638

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Fix docstrings formatting and add unnamed_distribution to glossary #6638

merged 1 commit into from
Apr 1, 2023

Conversation

alporter08
Copy link
Contributor

@alporter08 alporter08 commented Mar 30, 2023 •
edited
Loading

What is this PR about?
A new term in the glossary was added to define unnamed distributions so that we can use it as a reference in the docstrings.
Fixed censored and timeseries distributions. Is related to issue #5459

#DataUmbrellaPyMCSprint

Checklist

Documentation

  • see above

📚 Documentation preview 📚: https://pymc--6638.org.readthedocs.build/en/6638/

OriolAbril
OriolAbril approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc wise it looks great, hence the aproval. The definition for unnamed_distribution might need some work and external review, I tried to put something that wasn't too bad during today's sprint to get the PR ready to send.

@OriolAbril OriolAbril merged commit eb4e353 into pymc-devs:main Apr 1, 2023
@ricardoV94 ricardoV94 changed the title fix docstrings for censored and timeseries Fix docstrings for censored and timeseries Apr 14, 2023
@ricardoV94 ricardoV94 changed the title Fix docstrings for censored and timeseries Fix docstrings for censored and timeseries and add unnamed_distribution to glossary Apr 14, 2023
@ricardoV94 ricardoV94 changed the title Fix docstrings for censored and timeseries and add unnamed_distribution to glossary Fix censored and timeseries docstrings formatting and add unnamed_distribution to glossary Apr 14, 2023
@ricardoV94 ricardoV94 changed the title Fix censored and timeseries docstrings formatting and add unnamed_distribution to glossary Fix docstrings formatting and add unnamed_distribution to glossary Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriolAbril OriolAbril OriolAbril approved these changes

@ricardoV94 ricardoV94 ricardoV94 approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alporter08 @OriolAbril @ricardoV94