Make VI (posterior) mean and std accessible as a structured xarray #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6387 +/- ##
==========================================
- Coverage 94.79% 84.92% -9.87%
==========================================
Files 148 148
Lines 27730 27785 +55
==========================================
- Hits 26287 23597 -2690
- Misses 1443 4188 +2745
|
OriolAbril
approved these changes
Dec 13, 2022
ricardoV94
requested changes
Dec 13, 2022
There was a problem hiding this comment.
The variational tests were moved into tests/variational. I am not sure where this one should go, perhaps @Armavica can weigh in?
|
I think |
|
@fonnesbeck Any update on this? |
|
OK, tests moved over. |
|
@ricardoV94 are you happy with this? |
ricardoV94
requested changes
Jan 24, 2023
ricardoV94
reviewed
Jan 25, 2023
| @@ -977,7 +978,7 @@ def symbolic_random(self): | |||
|
|
|||
| @pytensor.config.change_flags(compute_test_value="off") | |||
| def set_size_and_deterministic( | |||
| self, node: Variable, s, d: bool, more_replacements: dict | None = None | |||
| self, node: Variable, s, d: bool, more_replacements: dict = None | |||
There was a problem hiding this comment.
Suggested change
| self, node: Variable, s, d: bool, more_replacements: dict = None | |
| self, node: Variable, s, d: bool, more_replacements: Optional[dict] = None |
There was a problem hiding this comment.
Unfortunately, the pre-commit hook reverts this back to dict | None = None. A little too agressive!
There was a problem hiding this comment.
You can commit with --no-verify to skip the pre-commit
ricardoV94
reviewed
Jan 25, 2023
ricardoV94
approved these changes
Jan 26, 2023
michaelosthege
changed the title
Co-authored-by: Michael Osthege <michael.osthege@outlook.com>
Co-authored-by: Michael Osthege <michael.osthege@outlook.com>
Co-authored-by: Michael Osthege <michael.osthege@outlook.com>
Co-authored-by: Michael Osthege <michael.osthege@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Moved from #6086 so that merge conflicts could be fixed. See original PR for details.