Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keep_size for arviz structures. #4006

Merged
merged 4 commits into from
Jul 12, 2020
Merged

Fix keep_size for arviz structures. #4006

merged 4 commits into from
Jul 12, 2020

Commits on Jul 10, 2020

  1. Fix posterior pred. sampling keep_size w/ arviz input. 

    Previously posterior predictive sampling functions did not properly
handle the `keep_size` keyword argument when getting an xarray Dataset
as parameter.

Also extended these functions to accept InferenceData object as input.
    @rpgoldman
    rpgoldman committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    de2d614 View commit details
    Browse the repository at this point in the history

  2. Reformatting.

    @rpgoldman
    rpgoldman committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    0cb6306 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2020

  1. Check type errors. 

    Make errors consistent across sample_posterior_predictive and fast_sample_posterior_predictive, and add 2 tests.
    @rpgoldman
    rpgoldman committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    eb59c5e View commit details
    Browse the repository at this point in the history

  2. Add changelog entry.

    @rpgoldman
    rpgoldman committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    1df5e4c View commit details
    Browse the repository at this point in the history