Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sample_posterior_predictive_w for V4 #4807

Closed
ricardoV94 opened this issue Jun 27, 2021 · 10 comments
Closed

Refactor sample_posterior_predictive_w for V4 #4807

ricardoV94 opened this issue Jun 27, 2021 · 10 comments
Labels
help wanted request discussion v4

Comments

@ricardoV94
Copy link
Member

No description provided.

@ricardoV94 ricardoV94 changed the title Refactor sample_posterior_predictive_w for V4. Refactor sample_posterior_predictive_w for V4 Jun 27, 2021
@ricardoV94 ricardoV94 added this to the vNext (4.0.0) milestone Jun 27, 2021
@ricardoV94 ricardoV94 modified the milestones: vNext (4.0.0), v4.0.1 Jul 2, 2021
@ricardoV94
Copy link
Member Author

Maybe we should deprecate this one instead?

@aloctavodia
Copy link
Member

And move the functionality to sample_posterior_predictive?

@ricardoV94
Copy link
Member Author

And move the functionality to sample_posterior_predictive?

I was discussing deprecating it altogether (not saying we should, just asking).

@aloctavodia
Copy link
Member

I think we should keep the functionality either in this function or in sample_posterior_predictive

@ricardoV94 ricardoV94 mentioned this issue Sep 30, 2021
Closed
13 tasks
@michaelosthege michaelosthege modified the milestones: v4.0.0b2, v4.0.0b3 Jan 7, 2022
@ricardoV94 ricardoV94 modified the milestones: v4.0.0b3, v4.0.0 Feb 3, 2022
@ricardoV94 ricardoV94 mentioned this issue Apr 1, 2022
Closed
3 tasks
@ricardoV94 ricardoV94 modified the milestones: v4.0.0, v4.1.0 Apr 1, 2022
@ricardoV94
Copy link
Member Author

@aloctavodia would you be interested/available to refactor this one? Nobody volunteered in a long time now :)

@twiecki
Copy link
Member

twiecki commented May 23, 2022

@zaxtax I think expressed interest.

@zaxtax
Copy link
Contributor

zaxtax commented May 24, 2022

I have something that works and passes unit tests, but is not efficient. Maybe I can open a WIP for it.

@ricardoV94
Copy link
Member Author

I have something that works and passes unit tests, but is not efficient. Maybe I can open a WIP for it.

Definitely!

@zaxtax zaxtax mentioned this issue May 24, 2022
Closed
@michaelosthege michaelosthege modified the milestones: v4.1.0, v4.2.0 Jul 2, 2022
@ricardoV94 ricardoV94 modified the milestones: v4.2.0, v4.3.0 Sep 14, 2022
@ricardoV94
Copy link
Member Author

I suggest removing this feature due to low interest from the community

@ricardoV94 ricardoV94 removed this from the v4.3.0 milestone Oct 27, 2022
@zaxtax
Copy link
Contributor

zaxtax commented Oct 29, 2022

@ricardoV94 I agree. I think this should be deprecated in favour of arviz-devs/arviz#2147 when it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted request discussion v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zaxtax @twiecki @aloctavodia @michaelosthege @ricardoV94