Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow linear model formula to extract variables from calling scope. #3382

Merged
merged 4 commits into from
Feb 27, 2019
Merged

Allow linear model formula to extract variables from calling scope. #3382

merged 4 commits into from
Feb 27, 2019

Conversation

adamboche
Copy link
Contributor

Resolving #3381, by adding an eval_env argument to from_formula, based on https://patsy.readthedocs.io/en/latest/API-reference.html#patsy.dmatrix.

lucianopaz
lucianopaz requested changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@lucianopaz lucianopaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks so much for the contribution! I think it's great! I have some comments though.

This change should be noted in the RELEASE-NOTES.md features section.

pymc3/glm/linear.py Show resolved Hide resolved
pymc3/glm/linear.py Show resolved Hide resolved
lucianopaz
lucianopaz requested changes Feb 25, 2019
View reviewed changes
RELEASE-NOTES.md Outdated Show resolved Hide resolved
@lucianopaz lucianopaz merged commit 6f7fafa into pymc-devs:master Feb 27, 2019
@lucianopaz
Copy link
Contributor

@adamboche, thanks so much!

@lucianopaz lucianopaz mentioned this pull request Feb 27, 2019
Closed
@adamboche adamboche deleted the glm_scope branch February 27, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianopaz lucianopaz lucianopaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamboche @lucianopaz