Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignored modules to Astroid module deny list #9504

Merged
merged 4 commits into from
May 12, 2024
Merged

Add ignored modules to Astroid module deny list #9504

merged 4 commits into from
May 12, 2024

Conversation

Jamie-
Copy link
Contributor

@Jamie- Jamie- commented Mar 15, 2024

Type of Changes

Type
✨ New feature

Description

Adds ignored modules to the Astroid deny list so they may be truly ignored as they will now not be imported at all.

Depends on Astroid change pylint-dev/astroid#2399

Closes #9442

@jacobtylerwalls jacobtylerwalls added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Mar 17, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.2.0 milestone Mar 17, 2024
@jacobtylerwalls jacobtylerwalls added the Enhancement ✨ Improvement to a component label Mar 17, 2024
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Will require an astroid release and upgrade that we could do just for this quickly since the value added is huge.

tests/lint/test_pylinter.py Outdated Show resolved Hide resolved

This comment has been minimized.

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @Jamie- I rebased your branch on main after we bumped astroid. Would you have a chance to look into the test failure by any chance? Thank you!

@jacobtylerwalls

This comment was marked as resolved.

This comment has been minimized.

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a test isolation fix. Thanks again for the PR!

@jacobtylerwalls jacobtylerwalls removed the Needs astroid update Needs an astroid update (probably a release too) before being mergable label May 12, 2024
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thank you !

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (7521eb1) to head (60add95).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9504      +/-   ##
==========================================
+ Coverage   95.82%   95.83%   +0.01%     
==========================================
  Files         173      174       +1     
  Lines       18835    18888      +53     
==========================================
+ Hits        18049    18102      +53     
  Misses        786      786              
Files Coverage Δ
pylint/lint/base_options.py 100.00% <ø> (ø)
pylint/lint/pylinter.py 96.44% <100.00%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 60add95

@jacobtylerwalls jacobtylerwalls merged commit fd6790b into pylint-dev:main May 12, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure import try/except over doubles pylint memory usage
3 participants