Reserve 'too-many-positional' / 'R0917' for later use #9278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9278 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 173 173
Lines 18761 18761
=======================================
Hits 17975 17975
Misses 786 786
|
|
Thank you! |
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
force-pushed
the
reserves-msgid-for-future-message
branch
from
e733ba4
to
99eb831
Compare
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 99eb831 |
charliermarsh
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Dec 4, 2023
## Summary Adds a rule that bans too many positional (i.e. not keyword-only) parameters in function definitions. Fixes #8946 Rule ID code taken from pylint-dev/pylint#9278 ## Test Plan 1. fixtures file checking multiple OKs/fails 2. parametrized test file
jacobtylerwalls
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
See astral-sh/ruff#8946
Refs #9099