Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deprecation] Make 'py_version' required for 'MessageDefinition.may_be_emitted' #8473

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Enacting planned deprecation.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Mar 21, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0a6 milestone Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #8473 (8f9fe66) into main (95a82dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8473   +/-   ##
=======================================
  Coverage   95.76%   95.77%           
=======================================
  Files         174      174           
  Lines       18358    18354    -4     
=======================================
- Hits        17581    17579    -2     
+ Misses        777      775    -2     
Impacted Files Coverage Ξ”
pylint/message/message_definition.py 100.00% <100.00%> (+2.63%) ⬆️

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 8f9fe66

@DanielNoord DanielNoord merged commit 77a392d into pylint-dev:main Mar 21, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the py-version-not-none-in-message-definition branch March 21, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants