Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deprecation] Remove 'do_exit' from the 'Run' constructor #8472

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Enacting planned deprecation.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Mar 21, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0a6 milestone Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #8472 (c4b0afb) into main (95a82dc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8472      +/-   ##
==========================================
+ Coverage   95.76%   95.78%   +0.01%     
==========================================
  Files         174      174              
  Lines       18358    18348      -10     
==========================================
- Hits        17581    17575       -6     
+ Misses        777      773       -4     
Impacted Files Coverage Ξ”
pylint/lint/run.py 87.69% <100.00%> (+1.12%) ⬆️
pylint/testutils/_run.py 100.00% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

@github-actions

This comment has been minimized.

@@ -123,7 +123,6 @@ def __init__(
args: Sequence[str],
reporter: BaseReporter | None = None,
exit: bool = True, # pylint: disable=redefined-builtin
do_exit: Any = UNUSED_PARAM_SENTINEL,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the sentinel as well right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch πŸ‘

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) March 21, 2023 11:00
@Pierre-Sassoulas Pierre-Sassoulas merged commit d659575 into pylint-dev:main Mar 21, 2023
@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit c4b0afb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants