Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[overgeneral-exceptions] Only handle qualified names #8411

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

I'm thinking of creating a pylint "check configuration" script, to avoid checking that at run time. Let me know what you think ;)

@Pierre-Sassoulas Pierre-Sassoulas added Breaking changes for 3.0 🦀 Maintenance Discussion or action around maintaining pylint or the dev workflow labels Mar 9, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0a6 milestone Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #8411 (a05bc74) into main (b2ab82a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8411   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files         175      175           
  Lines       18465    18465           
=======================================
  Hits        17668    17668           
  Misses        797      797           
Impacted Files Coverage Ξ”
pylint/checkers/exceptions.py 97.85% <100.00%> (ΓΈ)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit a05bc74

@ollie-iterators
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

I'm thinking of creating a pylint "check configuration" script, to avoid checking that at run time. Let me know what you think ;)

That sounds like a good change to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes for 3.0 🦀 Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants