Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep attributes for "bounds" variables #8924

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Apr 10, 2024

  1. Keep attributes for "bounds" variables

    Issue pydata#2921 is about mismatching time units between a time variable and
    its "bounds" companion.
    However, pydata#2965 does more than fixing pydata#2921, it removes all double
    attributes from "bounds" variables which has the undesired side effect
    that there is currently no way to save them to netcdf with xarray.
    Since the mentioned link is a recommendation and not a hard requirement
    for CF compliance, these attributes should be left to the caller to
    prepare the dataset variables appropriately if required.
    Reduces the amount of surprise that attributes are not written to disk
    and fixes pydata#8368.
    st-bender committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e8aa5c5 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. tests: Remove attributes checks for time bounds

    After encoding these and removing the removal of attributes from time
    bounds variables, these should be in the attributes. Removes the checks
    that they aren't.
    st-bender committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8c1b539 View commit details
    Browse the repository at this point in the history
  2. tests: Check different time_bounds calendar

    Makes the `time_bounds` calendar really different from `time` and checks
    that they are correctly encoded to be non-CF compliant.
    st-bender committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ba83823 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a011c47 View commit details
    Browse the repository at this point in the history