Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cf-coding #7654

Closed
wants to merge 22 commits into from
Closed

cf-coding #7654

wants to merge 22 commits into from

Commits on Apr 4, 2023

  1. implement coders, adapt tests

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d19d57a View commit details
    Browse the repository at this point in the history

  2. preserve boolean-dtype within encoding, adapt test

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    2e750e4 View commit details
    Browse the repository at this point in the history

  3. determine cf packed data dtype, adapt tests

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    0cd301b View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @kmuehlbauer
    pre-commit-ci[bot] authored and kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    7cfc6ac View commit details
    Browse the repository at this point in the history

  5. fix typing, fix if-clauses, add link to issue

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    bf4371d View commit details
    Browse the repository at this point in the history

  6. add comment ass per review

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    fe006df View commit details
    Browse the repository at this point in the history

  7. choose float64 if add_offset is not up to cf expectations

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    66628fc View commit details
    Browse the repository at this point in the history

  8. use scale_factor/add_offset in tests as specified by cf conventions

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    b6310e4 View commit details
    Browse the repository at this point in the history

  9. add test which checks add_offset being not conforming to cf standards

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    06ec16a View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @kmuehlbauer
    pre-commit-ci[bot] authored and kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    19ef234 View commit details
    Browse the repository at this point in the history

  11. convert to float32 to keep pydata#1840 in sync

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e877aa7 View commit details
    Browse the repository at this point in the history

  12. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @kmuehlbauer
    pre-commit-ci[bot] authored and kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    8cc7319 View commit details
    Browse the repository at this point in the history

  13. add more comments, add more typing

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    6a73653 View commit details
    Browse the repository at this point in the history

  14. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @kmuehlbauer
    pre-commit-ci[bot] authored and kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d6887cd View commit details
    Browse the repository at this point in the history

  15. add additional test, make _choose_float_dtype more explicit

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c8c3f14 View commit details
    Browse the repository at this point in the history

  16. Apply suggestions from code review 

    typing by @Illviljan

Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
    @kmuehlbauer @Illviljan
    kmuehlbauer and Illviljan committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    2f5709a View commit details
    Browse the repository at this point in the history

  17. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @kmuehlbauer
    pre-commit-ci[bot] authored and kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f215d01 View commit details
    Browse the repository at this point in the history

  18. Apply suggestions from code review 

    Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
    @kmuehlbauer @Illviljan
    kmuehlbauer and Illviljan committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c5cd53d View commit details
    Browse the repository at this point in the history

  19. Test against None, as 0 (False) is a valid input for add_offset. Chec… 

    …k for float32/64 only.
    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    986ffc6 View commit details
    Browse the repository at this point in the history

  20. apply astype in the right order to prevent loss of precision, more fi… 

    …llvalue fixes
    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    51f7515 View commit details
    Browse the repository at this point in the history

  21. add mask/scale roundtrip test for variable cf encoding/decoding

    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    8c074f0 View commit details
    Browse the repository at this point in the history

  22. separate CFMaskCoder test for multiple missing_values/__FillValues co… 

    …nflict, use _FillValue for missing_value if available
    @kmuehlbauer
    kmuehlbauer committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    031cac5 View commit details
    Browse the repository at this point in the history