Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove numbagg and numba from the upstream-dev CI #7416

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jan 4, 2023

Using the numpy HEAD together with numba is, in general, not supported (see numba/numba#8615). So in order to avoid the current failures and still be able to test numpy HEAD, this (temporarily) removes numbagg and numba (pulled in through numbagg), from the upstream-dev CI.

@github-actions github-actions bot added the CI Continuous Integration tools label Jan 4, 2023
@keewis
Copy link
Collaborator Author

keewis commented Jan 4, 2023

I think we should merge this fairly quickly, so we don't miss new errors (as far as I can tell, we accumulated about 850 failing tests, most of them related to datetime / cftime and pandas)

@max-sixty
Copy link
Collaborator

Thanks a lot @keewis , LGTM

@keewis
Copy link
Collaborator Author

keewis commented Jan 4, 2023

great, let's merge. The failing docs are unrelated.

@keewis keewis enabled auto-merge (squash) January 4, 2023 20:06
@keewis keewis disabled auto-merge January 4, 2023 20:07
@keewis keewis merged commit b93dae4 into pydata:main Jan 4, 2023
@keewis keewis deleted the upstream-dev-without-numba branch January 4, 2023 20:07
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 18, 2023
* main: (41 commits)
  v2023.01.0 whats-new (pydata#7440)
  explain keep_attrs in docstring of apply_ufunc (pydata#7445)
  Add sentence to open_dataset docstring (pydata#7438)
  pin scipy version in doc environment (pydata#7436)
  Improve performance for backend datetime handling (pydata#7374)
  fix typo (pydata#7433)
  Add lazy backend ASV test (pydata#7426)
  Pull Request Labeler - Workaround sync-labels bug (pydata#7431)
  see also : groupby in resample doc and vice-versa (pydata#7425)
  Some alignment optimizations (pydata#7382)
  Make `broadcast` and `concat` work with the Array API (pydata#7387)
  remove `numbagg` and `numba` from the upstream-dev CI (pydata#7416)
  [pre-commit.ci] pre-commit autoupdate (pydata#7402)
  Preserve original dtype when accessing MultiIndex levels (pydata#7393)
  [pre-commit.ci] pre-commit autoupdate (pydata#7389)
  [pre-commit.ci] pre-commit autoupdate (pydata#7360)
  COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement (pydata#7361)
  Avoid loading entire dataset by getting the nbytes in an array (pydata#7356)
  `keep_attrs` for pad (pydata#7267)
  Bump pypa/gh-action-pypi-publish from 1.5.1 to 1.6.4 (pydata#7375)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️
3 participants