Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weighted quantile #6059
Weighted quantile #6059
Changes from 42 commits
dcd1b24
875f766
217d2f0
278bed9
80ae229
77bb84e
58af567
15e3834
83e4210
2237399
b936e21
c94fa16
ab810d7
7bcf09e
8427637
3217962
7379d22
c8871d1
b26a5fc
42ebcc2
5aa22a4
abe253e
82147aa
784cedd
3ee62fd
4d6a4fd
9f93f55
8132320
4d7f5f5
c268ddd
db706aa
33ee96c
2ffd3d3
9806db8
15ee999
9559c87
73dde79
59714af
585b705
7443b82
42a6a49
2e0c16e
4186a24
1be1f92
5c251e0
9060f8e
c112d2c
d4ba8ee
fd0a54e
8bd83f9
343b47e
c298bd0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
da
andself.weights
must be broadcast-able and not necessarily have the same shape. Potentiallyapply_ufunc
takes care of this? (But I am not sure and would need to test).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to explicitly call align to make sure coordinates for da and weights match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still disagree with this -
align="inner"
will take care of the alignment. Or you need to convince me with a counter-example. I am still sure the following has to work:Check also:
or if you absolutely disagree with the second example do
align="exact"
this should allow the first one but not the second.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the principle, but in practice I'm having trouble getting it to work. Your first example doesn't work out of the box. I get