Explicitly state datetime units in array constructors in test_datetime_mean
#5463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
force-pushed
the
fix-NaT-units
branch
from
ac21000
to
e3d4859
Compare
keewis
approved these changes
Jun 12, 2021
There was a problem hiding this comment.
thanks, @spencerkclark, looks good to me.
The upstream-dev failure is the other issue from #5366, which is unrelated to this PR and will probably be fixed with the new numpy wheels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the
test_datetime_meanfailures reported in #5366. Pandas now requires that we make sure the units of datetime arrays are specified explicitly in array constructors: pandas-dev/pandas#36615 (comment).pre-commit run --all-files