Convert new_shape from list to tuple in _unstack_once #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's so small & reasonable & internal that it's probably fine not to have tests |
keewis
reviewed
May 17, 2021
| @@ -1579,7 +1579,7 @@ def _unstack_once( | |||
|
|
|||
| # Potentially we could replace `len(other_dims)` with just `-1` | |||
| other_dims = [d for d in self.dims if d != dim] | |||
| new_shape = list(reordered.shape[: len(other_dims)]) + new_dim_sizes | |||
| new_shape = tuple(list(reordered.shape[: len(other_dims)]) + new_dim_sizes) | |||
There was a problem hiding this comment.
probably not worth a new PR, but if .shape is always a tuple this could be simplified to
Suggested change
| new_shape = tuple(list(reordered.shape[: len(other_dims)]) + new_dim_sizes) | |
| new_shape = reordered.shape[: len(other_dims)] + tuple(new_dim_sizes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
new_shapeas alistbroke some checks in sparse..shapeis usually a tuple so I changednew_shapeto be a tuple as well. sparse arrays errors one step further down now instead, at the item assignment...pre-commit run --all-files