Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: ignore some warnings #4773

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Jan 6, 2021

Supresses 3 warnings we get in the test suite. Two are trivial. The third is PytestUnraisableExceptionWarning: Exception ignored in: CachingFileManager.__del__:

  • The test triggers an error is in CachingFileManager.__init__:

def test_file_manager_invalid_kwargs():
with pytest.raises(TypeError):
CachingFileManager(open, "dummy", mode="w", invalid=True)

  • It then tries to run __del__ but there is an error because an attribute is not available (as __init__ failed)

ref_count = self._ref_counter.decrement(self._key)

  • However, errors in __del__ are ignored, therefore we get a PytestUnraisableExceptionWarning

I decided to suppress the error and not fix CachingFileManager as I think that's nothing user-facing...

@keewis
Copy link
Collaborator

keewis commented Jan 6, 2021

I wonder why we have that test at all: we don't accept invalid or **kwargs as a parameter, which means that the TypeError is raised by the interpreter.

Edit: maybe the intention was to pass kwargs={"invalid": True}?

@mathause
Copy link
Collaborator Author

mathause commented Jan 6, 2021

I wonder why we have that test at all

Good point, thanks! When the test was written CachingFileManager had a **keywords argument. This is no longer the case so I'll remove the test.

@mathause mathause merged commit 01a0faf into pydata:master Jan 7, 2021
@mathause mathause deleted the fix_some_ci_warnings branch January 7, 2021 21:00
dcherian added a commit to TomNicholas/xarray that referenced this pull request Jan 18, 2021
* upstream/master: (342 commits)
  fix decode for scale/ offset list (pydata#4802)
  Expand user dir paths (~) in open_mfdataset and to_zarr. (pydata#4795)
  add a version info step to the upstream-dev CI (pydata#4815)
  fix the ci trigger action (pydata#4805)
  scatter plot by order of the first appearance of hue (pydata#4723)
  don't skip the scheduled CI (pydata#4806)
  coords: retain str dtype (pydata#4759)
  Fix interval labels with units (pydata#4794)
  Always force dask arrays to float in missing.interp_func (pydata#4771)
  Print number of variables in repr (pydata#4762)
  install conda as a library in the minimum dependency check CI (pydata#4792)
  Migrate CI from azure pipelines to GitHub Actions (pydata#4730)
  use conda.api instead of parallel calls to the conda binary (pydata#4775)
  Speed up missing._get_interpolator (pydata#4776)
  Remove special case in guess_engines (pydata#4777)
  improve typing of OrderedSet (pydata#4774)
  CI: ignore some warnings (pydata#4773)
  DOC: update hyperlink for xskillscore (pydata#4778)
  drop support for python 3.6 (pydata#4720)
  Trigger upstream CI on cron schedule (by default) (pydata#4729)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants