Add item to check for pint array type #4751
Conversation
|
This confirms that the issue in #4746 (comment) is this — lots of test failures — https://dev.azure.com/xarray/xarray/_build/results?buildId=4657&view=ms.vss-test-web.build-test-results-tab Any thoughts on how to fix? |
max-sixty
changed the title
|
|
||
| try: | ||
| import pint | ||
|
|
||
| pint_array_type = (pint.Quantity,) | ||
| except ImportError: # pragma: no cover | ||
| pint_array_type = () |
There was a problem hiding this comment.
it seems very strange to me that this would make some of the tests fail. pint didn't release recently, so this should not happen. I tried to rerun, let's see if that changes anything.
There was a problem hiding this comment.
this seems to be due to a circular import: pint.compat tries to import xarray objects. pytest.importorskip silences the import error somehow, so we get partially initialized modules. I'm somewhat surprised pint still does that, I thought we switched to comparing names some time ago.
There was a problem hiding this comment.
It was actually the other way around! We had to change from name-based comparison to actual type checks since both xarray and measurements have a Variable class, and they need to be treated completely differently (see hgrecco/pint#959).
There was a problem hiding this comment.
oh, I see. There should be a way to compare without importing (maybe using fully-qualified names like xarray.Variable or xarray.core.variable.Variable), but I guess to really fix this we need figure out #3950.
isort . && black . && mypy . && flake8whats-new.rstSeparate an item that may be causing some failures from #4746