Remove entrypoints in setup for internal backends #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_internal_backends
move BackendEtrypoints in common to solve circular dependecy
|
I merge it as it involves only the new APIv2 code. |
toddrjen
pushed a commit
to toddrjen/xarray
that referenced
this pull request
Dec 31, 2020
* add a dictionary for internal backends * remove entrypoints in setup.cfg * create global variable BACKEND_ENTRYPOINT move BackendEtrypoints in common to solve circular dependecy * fix and update tests * fix in tests_plugins to remove a warning
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to avoid conflicts during the transition period between the old backend implementation and the new plugins.
During the transition period will coexist both external backend plugins and internal ones.
Currently, if two plugins with the same name are detected, we just pick one randomly. It would be better to be sure to use the external one.
Main changes:
Remove from setup.cfg
Store in the internal backend and stored in the dictionary in plugins.py. The dictionary is updated with the external plugins detected by pkg_resources.
Move the class BackendEntrypoints in common.py to resolve a circular import.
Add a test
Related to Flexible Backend - AbstractDataStore definition #4309
Tests added
Passes
isort . && black . && mypy . && flake8