Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the ping @alexamici - this looks good to me. Happy to see this merged once we sort out the conflicts in #4187. |
|
#4187 has been merged, so this can go ahead again! |
|
Woops I didn't know that force pushing a branch would close the PR :/ I'll try to reopen this PR or create a new one. Sorry for the noise. |
|
@alexamici Force-pushing doesn't normally close it, so this is weird... |
|
the reason the PR was closed is that you removed the changes, so the diff to |
|
Thanks @keewis! So it is correct, I wanted to reset to master and re apply the changes. |
* Add docs re stable branch * Update HOW_TO_RELEASE.md Co-authored-by: keewis <keewis@users.noreply.github.com> Co-authored-by: keewis <keewis@users.noreply.github.com>
shoyer
approved these changes
Sep 23, 2020
jhamman
reviewed
Sep 23, 2020
jhamman
approved these changes
Sep 24, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the clean up of the messy if-else-chain from #3166. It should make adding the new back-end API easier.
The change is relatively trivial, but it touches code in
xr.open_datasetso extra care should be used by reviewers. We think the change is safe and it does pass all tests.isort . && black . && mypy . && flake8I cannot add reviewers myself, but we agreed this should go to @jhamman.