Assign default group name in groupby if name=None (#158) #4098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran across the issue describe in #158 the other day and decided to implement Stephan's suggestion of assigning a default name of 'group' to the DataArray passed to groupby if name=None. Previously when name=None on the DataArray a ValueError:
group
must have a name was raised.This is my first pull request so let me know if I missed anything. Thanks!
isort -rc . && black . && mypy . && flake8
whats-new.rst
for all changes andapi.rst
for new API