Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove PR pre-black instructions #3707

Merged
merged 1 commit into from
Jan 29, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions doc/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -384,21 +384,6 @@ from the root of the Xarray repository. Now ``black`` and ``flake8`` will be run
each time you commit changes. You can skip these checks with
``git commit --no-verify``.

.. note::

If you were working on a branch *prior* to the code being reformatted with black,
you will likely face some merge conflicts. These steps can eliminate many of those
conflicts. Because they have had limited testing, please reach out to the core devs
on your pull request if you face any issues, and we'll help with the merge:

- Merge the commit on master prior to the ``black`` commit into your branch
``git merge f172c673``. If you have conflicts here, resolve and commit.
- Apply ``black .`` to your branch and commit ``git commit -am "black"``
- Apply a patch of other changes we made on that commit: ``curl https://gist.githubusercontent.com/max-sixty/3cceb8472ed4ea806353999ca43aed52/raw/03cbee4e386156bddb61acaa250c0bfc726f596d/xarray%2520black%2520diff | git apply -``
- Commit (``git commit -am "black2"``)
- Merge master at the ``black`` commit, resolving in favor of 'our' changes:
``git merge d089df38 -X ours``. You shouldn't have any merge conflicts
- Merge current master ``git merge master``; resolve and commit any conflicts

Backwards Compatibility
~~~~~~~~~~~~~~~~~~~~~~~
Expand Down