fix pandas-dev tests

[dcherian]

• Closes Build failure with pandas master #3440

This PR makes DataArray.__init__ ignore the pandas attrs.

Not sure what we want to do about these attributes in the long term. One option would be to pop the name attribute, assign to DataArray.name and keep the rest as DataArray.attrs? But what if name clashes with the provided name?

[dcherian]

flake is complaining about

# Drop variables
    @overload  # noqa: F811
    def drop(
        self, labels: Union[Hashable, Iterable[Hashable]], *, errors: str = "raise"
    ) -> "Dataset":
        ...

    # Drop index labels along dimension
    @overload  # noqa: F811
    def drop(
        self, labels: Any, dim: Hashable, *, errors: str = "raise"  # array-like
    ) -> "Dataset":
        ...

./xarray/core/dataarray.py:1903:5: F811 redefinition of unused 'drop' from line 1896
./xarray/core/dataset.py:3531:5: F811 redefinition of unused 'drop' from line 3524

[max-sixty]

@dcherian you can # noqa those, they're going away anyway; I can sort in the drop PR

[crusaderky]

The F811 errors are a known issue that pyflakes has with @overload, already fixed in their git tip. For now just add # noqa: F811 wherever you get it

[max-sixty]

I merged the drop PR, so those overloads are now removed. Merging master should cause the tests to pass

[max-sixty]

Not sure what we want to do about these attributes in the long term. One option would be to pop the name attribute, assign to DataArray.name and keep the rest as DataArray.attrs? But what if name clashes with the provided name?

Agree! I think we could prioritize the supplied name above that in attrs. Another option would be raising an error if both were supplied.

[dcherian]

I'm merging this so we can continue testing against pandas master. Discussion can continue in #3497