Plot nans #1782
Plot nans #1782
Conversation
doc/whats-new.rst
Outdated
|
|
||
| - Bug fixes in :py:meth:`DataArray.plot.imshow`: all-NaN arrays and arrays | ||
| with size one in some dimension can now be plotted, which is good for | ||
| exploring satellite imagery. |
xarray/plot/plot.py
Outdated
| try: | ||
| xstep = (x[1] - x[0]) / 2.0 | ||
| except IndexError: | ||
| xstep = .1 |
There was a problem hiding this comment.
nit: I find xstep = .5 more intuitive here
There was a problem hiding this comment.
ignore my comment: it doesn't matter
There was a problem hiding this comment.
Either way, it would be good to add a comment here noting that the choice is arbitrary
xarray/tests/test_plot.py
Outdated
| @@ -624,6 +624,13 @@ def test_plot_nans(self): | |||
| clim2 = self.plotfunc(x2).get_clim() | |||
| self.assertEqual(clim1, clim2) | |||
|
|
|||
| def test_can_plot_all_nans(self): | |||
| # regression test for issue #1780 | |||
| DataArray(np.full((2, 2), np.nan)).plot.imshow() | |||
There was a problem hiding this comment.
Do this instead:
self.plotfunc(DataArray(np.full((2, 2), np.nan)))Common2dMixin will check that all 2d functions work consistently
xarray/tests/test_plot.py
Outdated
| DataArray(np.full((2, 2), np.nan)).plot.imshow() | ||
|
|
||
| def test_can_plot_axis_size_one(self): | ||
| DataArray(np.ones((1, 1))).plot.imshow() |
Zac-HD
force-pushed
the
plot-nans
branch
2 times, most recently
from
6702761
to
ed8b62b
Compare
doc/whats-new.rst
Outdated
| - Bug fixes in :py:meth:`DataArray.plot.imshow`: all-NaN arrays and arrays | ||
| with size one in some dimension can now be plotted, which is good for | ||
| exploring satellite imagery. (:issue:`1780`) | ||
| - Bug fixes in :py:meth:`DataArray.plot.imshow`: all-NaN arrays and arrays |
There was a problem hiding this comment.
This entry is now repeated twice :)
There was a problem hiding this comment.
Ah, rebasing! Fixed 😄
xarray/plot/plot.py
Outdated
| try: | ||
| xstep = (x[1] - x[0]) / 2.0 | ||
| except IndexError: | ||
| xstep = .1 |
There was a problem hiding this comment.
Either way, it would be good to add a comment here noting that the choice is arbitrary
xarray/plot/utils.py
Outdated
| @@ -165,6 +165,10 @@ def _determine_cmap_params(plot_data, vmin=None, vmax=None, cmap=None, | |||
|
|
|||
| calc_data = np.ravel(plot_data[~pd.isnull(plot_data)]) | |||
|
|
|||
| # Handle all-NaN input data gracefully | |||
| if calc_data.size == 0: | |||
| calc_data = np.array(0.0) | |||
There was a problem hiding this comment.
I suppose the colorbar get the wrong data in this case, but it's still better than an error message?
Again, please comment that the value 0 is arbitrary.
There was a problem hiding this comment.
There is no data to give the colorbar in this case, so it uses Matplotlib defaults. Works beautifully for faceted plots of image timeseries though 😄
|
Thanks @Zac-HD ! |
|
No problem! Do you have any idea when this might be released? I can install from git in my own environment, but I probably can't convince GA to do that in their production environment 😄 |
|
There are a few other bugs that fell out of the v0.10 release. Once we fix those it would make sense issue another release soon... Maybe within a few weeks? |
git diff upstream/master **/*py | flake8 --diff(remove if you did not edit any Python files)whats-new.rstfor all changesCC @fmaussion for review; @BexDunn for interest