Dataset.copy() to preserve encoding #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for merge if there's no objections |
4 tasks
|
Pending the outcome of our conversation on #1586, this looks good to me. |
jhamman
reviewed
Oct 7, 2017
| @@ -1434,6 +1435,7 @@ def test_copy(self): | |||
|
|
|||
| for copied in [data.copy(deep=False), copy(data)]: | |||
| self.assertDatasetIdentical(data, copied) | |||
| self.assertEqual(data.encoding, copied.encoding) | |||
There was a problem hiding this comment.
note on behalf of @MaximilianR -
this can just be assert data.encoding == copied.encoding
There was a problem hiding this comment.
Doesn't assertEqual produce better output in case of failure?
There was a problem hiding this comment.
Pytest satisfies all your desires!
There was a problem hiding this comment.
@crusaderky - pytest has nice introspection for this sort of thing. https://docs.pytest.org/en/latest/assert.html#making-use-of-context-sensitive-comparisons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffwhats-new.rstfor all changes andapi.rstfor new API