New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise error if objects other than datasets are passed to save_mfdataset #1556

Merged

jhamman merged 1 commit into pydata:master from jhamman:fix/1555

Sep 7, 2017

Member

jhamman commented Sep 7, 2017

Closes TypeError: DataArray.name or Dataset key must be either a string or None for serialization to netCDF files #1555
Tests added / passed
Passes git diff upstream/master | flake8 --diff
Fully documented, including whats-new.rst for all changes and api.rst for new API


          raise error if objects other than datasets are passed to save_mfdatas…

af08f69

…et()

jhamman requested a review from shoyer

September 7, 2017 03:10

shoyer approved these changes

View reviewed changes

doc/Makefile

@@ @@ -18,6 +19,7 @@ I18NSPHINXOPTS = $(PAPEROPT_$(PAPER)) $(SPHINXOPTS) . @@
               help:
               	@echo "Please use \`make <target>' where <target> is one of"
               	@echo "  html       to make standalone HTML files"
+              	@echo "  livehtml   Make standalone HTML files and rebuild the documentation when a change is detected. Also includes a livereload enabled web server"

Member

shoyer Sep 7, 2017

Nice. I didn't realize this was a thing!

jhamman merged commit 98a05f1 into pydata:master

jhamman deleted the fix/1555 branch

September 7, 2017 07:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet