Alternate approach to serializing netcdfs for dask.distributed #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, so you've handled the leaf case and everything else follows naturally from there thanks to pickle. Nice. |
|
This seemed to work, see dask/distributed#629 comment. |
This was referenced Nov 8, 2016
|
Note, I did get a memory error for usage via |
|
Closing in favor of #1128, which simply makes all datastores pickle-able. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1083
Based on @mrocklin's suggestion of (ab)using pickle.
The good news is that this version can handle many more types out of the box (no datetime64 or timedelta64, though), and I don't need to do anything special for all of my other special array types further away from netCDF files.
cc @pwolfram -- maybe you'll have more luck with this version?