Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes are currently kept when arrays are resampled, and not when datasets are resampled #828

Closed
mcgibbon opened this issue Apr 16, 2016 · 4 comments
Closed

Attributes are currently kept when arrays are resampled, and not when datasets are resampled #828

mcgibbon opened this issue Apr 16, 2016 · 4 comments
Labels
topic-metadata Relating to the handling of metadata (i.e. attrs and encoding)

Comments

@mcgibbon
Copy link
Contributor

Because line 323 of groupby.py copies attributes from a DataArray to its resampling output (it shouldn't), attributes are kept in many cases when DataArrays are resampled (and not kept for similar cases when Datasets are resampled).
@shoyer
Copy link
Member

shoyer commented Apr 16, 2016

I agree, this is a bug. We should make this consist and follow the keep_attrs argument.

@mcgibbon
Copy link
Contributor Author

@shoyer I've corrected this in a PR I'll submit shortly.

@mcgibbon mcgibbon mentioned this issue Apr 16, 2016
Merged
@shoyer
Copy link
Member

shoyer commented Apr 17, 2016

Awesome, thanks!

On Sat, Apr 16, 2016 at 4:51 PM, mcgibbon notifications@github.com wrote:

@shoyer https://github.com/shoyer I've corrected this in a PR I'll
submit shortly.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#828 (comment)

@shoyer
Copy link
Member

shoyer commented Apr 20, 2016

Fixed by #829

@shoyer shoyer closed this as completed Apr 20, 2016
@jhamman jhamman mentioned this issue Oct 9, 2017
Open
@TomNicholas TomNicholas mentioned this issue Oct 12, 2018
Merged
4 tasks
@TomNicholas TomNicholas added the topic-metadata Relating to the handling of metadata (i.e. attrs and encoding) label Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-metadata Relating to the handling of metadata (i.e. attrs and encoding)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shoyer @mcgibbon @TomNicholas